chore: colors update ternary to if else #55700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55700 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02%
==========================================
Files 654 654
Lines 187594 187605 +11
Branches 36090 36083 -7
==========================================
- Hits 165870 165859 -11
- Misses 14980 15000 +20
- Partials 6744 6746 +2
|
|
Please amend your commit to follow the commit guidelines. Also, the GitHub bot doesn't like merge commits, so a rebase would be nice |
RedYetiDev
reviewed
Nov 3, 2024
lib/internal/util/colors.js
Outdated
| }, | ||
| }; | ||
|
|
||
| module.exports.refresh(); | ||
| module.exports.refresh(); |
There was a problem hiding this comment.
Suggested change
| module.exports.refresh(); | |
| module.exports.refresh(); | |
|
Why? This is purely stylistic. What's stopping a future PR from undoing this change, as there's no lint rule enforcing it. |
dancastillo
force-pushed
the
chore-colors-update-ternary-to-if-else
branch
from
b691d01
to
cab5123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore: Update for comment from ternary to if else